[CORL-3030]: New notification types #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-funk
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes add new notification types to notifications, including replies, staff replies, and comment approvals. It also adds in checks, such as that a user isn't replying to themselves and the reply isn't coming from an ignored user (in those cases, no notification is needed).
Set as draft pending updated copy/design around how the reply/staff reply/approve/feature notifications should look.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
Adds a
REPLY_STAFFnotification type. AddscommentReplyto notifications so that we can use it in reply notifications.Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can test these changes by replying to users as a regular commenter and as a staff commenter. Also approve/feature stories (should see the notifications appear, but what will be shown for the comments is still pending).
Were any tests migrated to React Testing Library?
How do we deploy this PR?