[CORL-3031]: User preferences for in-page notifications #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifications are email
nick-funk
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes update the user preferences to show in-page notification settings (with provided defaults) as well as the ability for the user to update their in-page notification settings.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
These changes add
inPageNotificationsto the user model with 6 initial configuration fields. They also add in theupdateUserInPageNotificationSettingsmutation to change a user'sinPageNotificationssettings.Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
Make sure that
Z_KEYisn't enabled. See that email notification settings are showing in user preferences for a logged-in user. See that they can still be updated, etc., as expected.Enable
Z_KEY. See that now in-page notification settings are showing. You should see an active bell icon beside theIn-page notificationsheader in user preferences. Enable/disable the settings and see that the changes are correctly persisted to the user model for the commenter you are logged in as.Were any tests migrated to React Testing Library?
How do we deploy this PR?