[CORL-3042]: Fix feature/unfeature counts bug #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes address a bug where if a comment was featured or unfeatured multiple times by different mods, then the count would be updated. This makes it so that if a comment is already featured and someone tries to feature it again, it doesn't update counts or otherwise re-feature. If a comment is already unfeatured and someone tries to unfeature it again, it doesn't update counts or otherwise re-unfeature.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
Does this PR introduce any new environment variables or feature flags?
If any indexes were added, were they added to
INDEXES.md?How do I test this PR?
See that if you have two windows open with different logged-in mods, and each mod features the same comment, the count will increment by 1 in both cases and it will say "featured". On refresh, the count will still be the same and the comment will still be featured.
See that if you have two windows open with different logged-in mods, and each mod unfeatures the same comment, the count will decrement by 1 in both cases and it will say "unfeatured". On refresh, the count will still be the same and the comment will be unfeatured.
Were any tests migrated to React Testing Library?
How do we deploy this PR?