Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finnish translations: Fix notification email footer issues #4524

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

juhog
Copy link

@juhog juhog commented Feb 5, 2024

What does this PR do?

Finnish language notification emails are missing both the organization name and the unsubscribe link. As described in issue #4522.

This PR fixes both of those issues. Also, this PR removes unnecessary trailing white-space from some lines in the translations file.

Before After
email_footer email fix

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 9837cfc
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65c15ee0db6a3600088d5089

Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates! I left one small comment about how it would be great to get the organization link added in around the updated { $organizationName } variable with these changes as well.

server/src/core/server/locales/fi-FI/email.ftl Outdated Show resolved Hide resolved
@juhog
Copy link
Author

juhog commented Feb 12, 2024

@kabeaty Thanks for the review. Is there something I can do to get the PR merged? I'm not quite familiar with the process yet.

@kabeaty
Copy link
Contributor

kabeaty commented Feb 12, 2024

@kabeaty Thanks for the review. Is there something I can do to get the PR merged? I'm not quite familiar with the process yet.

@juhog I'm working on the next release now and will be merging it in soon. So nothing else required from you now. Thanks for asking!

@kabeaty kabeaty added this pull request to the merge queue Feb 12, 2024
Merged via the queue into coralproject:develop with commit 5053586 Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants