Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3094]: my profile preferences link styles in notifications container #4537

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Feb 14, 2024

What does this PR do?

These changes update styles so that the link to adjust preferences in a user's profile for in-page notifications looks good at smaller sizes too.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can view the floating notifications and the mobile notifications container. See that the link about adjusting notification preferences at the top of the notifications container looks good now on both.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

@kabeaty kabeaty requested a review from nick-funk February 14, 2024 20:30
Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nick-funk nick-funk merged commit d9fe539 into epic/notifications Feb 14, 2024
2 checks passed
@nick-funk nick-funk deleted the fix/CORL-3094-my-profile-preferences branch February 14, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants