[CORL-3095]: disable e-mail notifications when in-page notifications is enabled #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes make it so that when in-page notifications is enabled, e-mail notifications are disabled. There is also a note about this added to the admin configuration.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can enable in-page notifications. See that e-mail notifications and their settings are no longer shown. Also see that if you reply to a user (who has e-mail settings for replies enabled) while in-page notifications is enabled, that e-mail notification won't get sent out.
If you disable in-page notifications again, they can then change their e-mail settings and e-mail notifications are sent out again on reply, etc. In-page notification settings are no longer shown in this case, and neither are in-page notifications.
Were any tests migrated to React Testing Library?
How do we deploy this PR?