Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3080]: update email domain table in admin #4543

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Feb 15, 2024

What does this PR do?

These changes improve the organization of email domains for which rules (such as ban new users and always pre-mod comments) have been created. It only shows the list on clicking to show, ensures the order is most recently added at the top, and allows for filtering of the domains by whether they are set to ban or always pre-mod.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can go into Configure-->Moderation-->Users as an admin and find the Email domains section at the bottom of the page. Show/hide current email domains. Filter them. Add/edit/delete them.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 023ec1e
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65ce2bc08798bf0008e21e7f

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tessalt tessalt added this to the v8.8.1 milestone Mar 14, 2024
@tessalt tessalt added this pull request to the merge queue Mar 14, 2024
Merged via the queue into develop with commit 7d1429b Mar 14, 2024
6 checks passed
@tessalt tessalt deleted the feat/CORL-3080-update-email-domain-list branch March 14, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants