Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/unarchiving timeout #4544

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Hotfix/unarchiving timeout #4544

merged 4 commits into from
Feb 15, 2024

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

Increases timeouts on jobs and queries when unarchiving to longer than 30 seconds.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

  • pull a very large set of archived comments from a prod/staging cluster
  • unarchive a story
  • see that it takes a while, but succeeds

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

Hotfix release into main then merge main back into develop.

this will prevent the 30 second unarchive timeout from happening
@nick-funk nick-funk requested a review from kabeaty February 15, 2024 19:03
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit ea56da5
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65ce6666c4b1c80008fbff7f

@nick-funk nick-funk changed the base branch from develop to main February 15, 2024 19:32
@nick-funk nick-funk merged commit 3b9f452 into main Feb 15, 2024
2 checks passed
@nick-funk nick-funk deleted the hotfix/unarchiving-timeout branch February 15, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants