[CORL-3103]: Make protected email domain bans customizable #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
nick-funk
approved these changes
Mar 14, 2024
| @@ -250,7 +249,7 @@ it("does not display ban domain option for moderated domain", async () => { | |||
| }); | |||
|
|
|||
| it("does not display ban domain option for protected domain", async () => { | |||
| const protectedDomain = PROTECTED_EMAIL_DOMAINS.values().next().value; | |||
| const protectedDomain = "gmail.com"; | |||
There was a problem hiding this comment.
this is a nice cleanup, makes the tests clearer, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes update to make protected email domains customizable by tenant in admin configuration --> Moderation --> Users --> Email domain. The default list is the current protected email domains list.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
This adds
protectedEmailDomainsto settings.Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can test this PR by going into the admin and updating the protected email domain bans. See that the default is the correct protected email domain list, and you can add and remove domains and save. If you have an incorrectly formatted email domain, you will see a validation error below if you try to save.
If you try to add a protected email domain that you add to the list to ban all commenter accounts, you will get an error. If you go into the Community tab and try to ban a commenter with an email in the protected email domains list, you will not see an option to do an email domain ban. If you try to ban a commenter with an email not in the protected email domains list, you should see this option.
Were any tests migrated to React Testing Library?
How do we deploy this PR?