[CORL-3104]: Email domain ban confirmation #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes add a confirmation to email domain bans, so that when selecting this option, the moderator must type "ban" to confirm they want to ban all commenter accounts for an email domain.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
As a moderator or admin, go to the Community tab in the admin. In the Status column dropdown for a user, select "Manage Ban". In the ban modal that pops up, see the Email domain ban section. Click the checkbox to
Ban all commenter accounts from { domain }. See thatSaveis now disabled and a warning shows saying this will prevent any commenter from using this email domain and that the user must type inbanto confirm. Oncebanis typed into the input, then theSavebutton should be enabled. ClickSaveand see that it's applied as expected.Were any tests migrated to React Testing Library?
How do we deploy this PR?