Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: show different rejection message for rejected pending comments #4569

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

When a comment is in the pending state (not visible stream side due to pre-moderation) and is then rejected, show a slightly different text that indicates it was never visible stream side (does not say it was removed from stream).

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

Adds a previousStatus field to notifications.

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

None

How do I test this PR?

  • post a comment as a commenter
  • using an admin/mod, reject the comment
  • check the commenter's notifications and see they have a rejected notification saying their comment violated guidelines and was removed
  • set a commenter to always premoderate in the community tab
  • post a comment as that commenter
  • using an admin/mod, reject this comment
  • check the commenter's notifications and see that they have a different message that says it violated guidelines, but does not say it was removed from the stream

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

Merge into epic branch.

@nick-funk nick-funk requested a review from kabeaty March 7, 2024 17:04
Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit e806e5a
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65e9f3992f5b0200085def47

@nick-funk nick-funk changed the base branch from develop to epic/notifications March 7, 2024 17:04
Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nick-funk nick-funk merged commit c1d264d into epic/notifications Mar 7, 2024
6 checks passed
@nick-funk nick-funk deleted the notifications/premod-reject-wording branch March 7, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants