Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make rejectComment work for archived comments #4621

Merged
merged 3 commits into from
May 29, 2024

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

  • passes archived state to reject comment during api mutation

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

  • Setup Coral with live and archived databases
  • Comment on a story
  • Archive that story
  • Reject the comment via mutation that you posted to the story
  • See that the comment is correctly found and rejected via the API mutation call

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge into develop
  • Cut a release

@nick-funk nick-funk requested review from tessalt and kabeaty May 28, 2024 19:29
Copy link

netlify bot commented May 28, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 6ddd333
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/665633bae664ae00094455fb

@tessalt tessalt merged commit e8787fb into develop May 29, 2024
6 checks passed
@tessalt tessalt deleted the fix/rejectComment-archived-comments branch May 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants