Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-tag-push step in GitHub Actions #4627

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

nick-funk
Copy link
Contributor

@nick-funk nick-funk commented May 30, 2024

What does this PR do?

  • updates the setup-buildx and build-tag-push steps in our actions runners
  • fixes the missing distutils packages for pnpm to install our dependencies

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

Check the build steps/actions in GitHub and see they passed

Proof of it working here: https://github.com/coralproject/talk/actions/runs/9307222322/job/25618059747

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

Merge into develop

@nick-funk nick-funk requested review from tessalt and kabeaty May 30, 2024 19:04
Copy link

netlify bot commented May 30, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 5cef7d1
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6658ce515294f20009a8e0ce

also remove debug testing action from `build-and-test.yml`
@nick-funk nick-funk marked this pull request as ready for review May 30, 2024 19:07
@nick-funk nick-funk enabled auto-merge May 30, 2024 19:12
@nick-funk nick-funk added this pull request to the merge queue May 30, 2024
Merged via the queue into develop with commit 1df2c6e May 30, 2024
6 checks passed
@nick-funk nick-funk deleted the fix/build-tag-push branch May 30, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants