Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3177]: update to grab the ORIGIN from the count.js script for #4638

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Jun 28, 2024

What does this PR do?

This updates to grab the ORIGIN from the count.js script for comment counts.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can check that the origin is correctly grabbed from the script on the comment embed story page.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit c746b08
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/667ee8006dcd210008dceb07

@kabeaty kabeaty requested review from nick-funk and tessalt June 28, 2024 16:49
@tessalt tessalt added this pull request to the merge queue Jul 2, 2024
@tessalt tessalt removed this pull request from the merge queue due to a manual request Jul 2, 2024
@tessalt tessalt merged commit d0cc5e0 into develop Jul 2, 2024
6 checks passed
@tessalt tessalt deleted the bug/CORL-3177-count-script-origin branch July 2, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants