[CORL-3179]: Create notification on previously rejected comment being approved if DSA is enabled #4671
Conversation
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
| return getMessage( | ||
| bundles, | ||
| "notifications-yourPreviouslyRejectedCommentHasBeenApproved", | ||
| "Your comment was previously rejected. It has now been restored to the page." |
There was a problem hiding this comment.
"restored to the page"
Have we checked this copy with Andrew?
There was a problem hiding this comment.
This is what was included in the issue. @losowsky can you confirm that this is the copy we want for this?
There was a problem hiding this comment.
I think Nick is right, let's change it to "Your comment was previously rejected. It has now been approved."
There was a problem hiding this comment.
Updated...thank you both!
| if (tenant.dsa?.enabled) { | ||
| if (previousComment?.status === GQLCOMMENT_STATUS.REJECTED) { |
There was a problem hiding this comment.
am I missing something on the nested if's here? Can it be simplified to the following?
if (tenant.dsa?.enabled && previousComment?.status === GQLCOMMENT_STATUS.REJECTED) {
There was a problem hiding this comment.
yep, it can be...updating! thanks
There was a problem hiding this comment.
Looks good to me, only thought is to confirm the copy with Andrew. Could just be me but I don't think we use "page" in our terminology when referring to the comment stream so it stuck out to me.
If I'm wrong and that was the expected copy, am cool with it, feel free to merge!
tessalt
deleted the
feat/CORL-3179-dsa-rejected-comments-approved-update
branch
What does this PR do?
If DSA is enabled, then with these changes, we now create a notification if a comment was previously rejected (whether automatically for including a banned word or by a moderator) and then is approved.
If DSA is not enabled, then there are no changes; no notification is created when a comment is rejected, and there is also no subsequent notification created if it is later approved after rejection.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
This adds a new type to the
NOTIFICATION_TYPEenum ofPREVIOUSLY_REJECTED_COMMENT_APPROVED.Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can test out these changes by:
Then, also:
Were any tests migrated to React Testing Library?
How do we deploy this PR?