feat: aligns logger with caddy #50
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| return true | ||
| } | ||
|
|
||
| type noopEvent struct{} |
There was a problem hiding this comment.
In the end I think it is worth to export the noop event, maybe as a variable or just the constructor @anuraaga
There was a problem hiding this comment.
It seems this is because of the level check in this code - I wonder if level checks are supposed to happen at a higher level in coraza (these become just LogWriter or something). Maybe too much to change now.
Another option could be to delegate to noop logger, which is public, instead of returning noopEvent - what about that?
There was a problem hiding this comment.
Checks will happen if we need to adapt logger with an underlying platform logger (in this case zap). I will leave this as it is now and if in the future we need the noop even to be exported we can export.
This PR aligns the logger with the one provided by caddy (zap).