chore: deprecates Include config field. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be done in 'directives' field and only causes confusion with respect to ordering of rules which is something that matters when it comes to disruptive actions.
fzipi
reviewed
Apr 1, 2023
|
Maybe the wording isn't the best one bue Include is a known directive in
modsecurity/coraza (maybe it isn't part of seclang and it is more an Apache
thing)
…On Sun, 2 Apr 2023, 00:50 Felipe Zipitría, ***@***.***> wrote:
***@***.**** commented on this pull request.
There in no Include in seclang. Are we extending it?
------------------------------
In coraza.go
<#51 (comment)>
:
> if len(m.Include) > 0 {
+ m.logger.Warn("Include field is deprected, do the include in directives instead")
⬇️ Suggested change
- m.logger.Warn("Include field is deprected, do the include in directives instead")
+ m.logger.Warn("include field is deprecated, please use the Include directive instead")
—
Reply to this email directly, view it on GitHub
<#51 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAXRAQBHCWEV7TA4LFDW7CWNDANCNFSM6AAAAAAWP33LVI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Then let's change the wording so we don't confuse users. With this in mind, the integration has the requirement of providing this feature, or things won't work as expected... |
|
I don't think we need to provide this. Whenever you use coraza you are used
to do `Include @owasp_crs/*.conf` in the directives isn't? We expect the
same here.
…On Sun, 2 Apr 2023, 01:10 Felipe Zipitría, ***@***.***> wrote:
Then let's change the wording so we don't confuse users. With this in
mind, the integration has the requirement of providing this feature, or
things won't work as expected...
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAXY6KYQ36CCNFRVIYLW7CYYBANCNFSM6AAAAAAWP33LVI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Ok, now I get it (I thought we were discussing coraza, instead of the connector 🤦). If you change the wording with the suggestion I'll approve. |
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
fzipi
approved these changes
Apr 3, 2023
jcchavezs
commented
Apr 5, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be done in 'directives' field and only causes confusion with respect to ordering of rules which is something that matters when it comes to disruptive actions.