Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replaces filesystem library. #52

Merged
merged 7 commits into from
Apr 28, 2023
Merged

fix: replaces filesystem library. #52

merged 7 commits into from
Apr 28, 2023

Conversation

jcchavezs
Copy link
Member

No description provided.

@jcchavezs jcchavezs mentioned this pull request Apr 5, 2023
Closed
@jcchavezs
Copy link
Member Author

Since we proved the mergefs library worked at jcchavezs/coraza-httpbin#4 and here I will merge this as a quickfix.

@jcchavezs jcchavezs requested a review from M4tteoP April 24, 2023 21:09
@M4tteoP
Copy link
Member

M4tteoP commented Apr 26, 2023

I agree about the mergefs usage, but surprised about the failing e2e tests 🤔

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jcchavezs jcchavezs merged commit 27c68af into master Apr 28, 2023
@jcchavezs jcchavezs deleted the fixes_filesystem branch April 28, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4tteoP M4tteoP M4tteoP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcchavezs @M4tteoP