Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example points to v4, readme #15

Merged
merged 1 commit into from
Mar 11, 2024
Merged

example points to v4, readme #15

merged 1 commit into from
Mar 11, 2024

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Mar 8, 2024 •
edited
Loading

This PR:

  • Makes the example work with the tag
  • Adds a bit more context on the readme (follows slack question)
Repo/coraza-coreruleset/example  example-v4-readme ✔                                                                                                                                                                                                                     
▶ go run main.go
Success

jcchavezs
jcchavezs reviewed Mar 9, 2024
View reviewed changes
example/go.mod Outdated
@@ -3,7 +3,7 @@ module github.com/corazawaf/coraza-coreruleset/v4/example
go 1.18

require (
github.com/corazawaf/coraza-coreruleset v0.0.0-20240226094324-415b1017abdc
github.com/corazawaf/coraza-coreruleset/v4 v4.0.0-coraza.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we agreed on not having the coraza suffix in #11 (comment) and instead cut our own patch version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to v4.0.0 ✅

@M4tteoP M4tteoP force-pushed the example-v4-readme branch from b566229 to 811bacf Compare March 9, 2024 14:58
@M4tteoP M4tteoP merged commit f8119fa into corazawaf:main Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcchavezs jcchavezs jcchavezs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M4tteoP @jcchavezs