Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to CRS v4.7.0, adds a bit of verbosity to downloadDeps #28

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Oct 4, 2024

No description provided.

@M4tteoP M4tteoP requested a review from jcchavezs October 4, 2024 13:11
@fzipi
Copy link
Member

fzipi commented Nov 13, 2024

Can we use renovatebot for this?

@M4tteoP
Copy link
Member Author

M4tteoP commented Nov 13, 2024

If it can update https://github.com/corazawaf/coraza-coreruleset/blob/main/version.go and then call go run mage.go downloadDeps, probably yes

Copy link
Member

@jptosso jptosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it makes sense to automate this in the near future

@M4tteoP
Copy link
Member Author

M4tteoP commented Nov 13, 2024

Merging, for automation I opened #29

@M4tteoP M4tteoP merged commit 3989e78 into main Nov 13, 2024
3 checks passed
@M4tteoP M4tteoP deleted the crs47 branch November 13, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants