Fix CRS 4.0.0 rc2 adding a cleanup phase #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
reviewed
Nov 3, 2023
magefile.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if strings.HasPrefix(d.Name(), "REQUEST-") || strings.HasPrefix(d.Name(), "RESPONSE-") { |
There was a problem hiding this comment.
Wonder about this, shall we just remove everything? Otherwise could you add a comment on why this condition?
There was a problem hiding this comment.
Refactored to make it more explicit. The goal is to not delete .go files that belong to this repo
There was a problem hiding this comment.
I am lost now, do we iterate over root files in this repo? Can't we just delete rules folder and tests folder?
jcchavezs
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add a cleanup phase before downloading the new CRS. It is required cause otherwise deleted files from the official CRS repo are not going to be overridden/deleted here. It leads to polluting the latest download with leftovers from previous downloads