[WIP] Istio e2e

[jcchavezs]

No description provided.

[jcchavezs]

@nacx would you have a look at the e2e? Whenever I add the wasmplugin it fails to pull the image that I explicitly loaded a few steps before.

[nacx]

I'm not sure about the kind load internals, but I think it doesn't use a proper registry there, but has the images ready for k8s. Images pointed by WasmPlugins are downloaded by the Istio sidecar using the go-containerregistry library. That is, it expects a proper container registry and to be able to pull images from there. Can you try configuring the e2e tests to pull images from a public registry, just to discard issues with how kind load?

[nacx]

Having another thought on this, I think we should not have Istio-specific e2e tests here.

Having Istio-specific APIs here like the WASM plugin API just brings complexity and maintenance burden to this project for very little gain. In the end, the objective of this would be to make sure we remain Envoy compatible with whatever Envoy version matrix we agree on, but I think having Isito-specific tests here is out of scope and only brings unnecessary complexity.

[jcchavezs]

Mixed feelings here. Although that is true we provide a docker image that fits the wasm plugin spec from istio and that artifact is not tested (although we do our best effort with istio tests).

…

On Tue, 15 Nov 2022, 11:13 Ignasi Barrera, ***@***.***> wrote: Having another thought on this, I think we should not have Istio-specific e2e tests here. Having Istio-specific APIs here like the WASM plugin API just brings complexity and maintenance burden to this project for very little gain. In the end, the objective of this would be to make sure we remain Envoy compatible with whatever Envoy version matrix we agree on, but I think having Isito-specific tests here is out of scope and only brings unnecessary complexity. — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYATCFZ5OPAGWVIDXY6DWINO2ZANCNFSM6AAAAAASAHLFPA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[nacx]

If you really want to test that, the way to test it not by requiring Istio and an entire k8s setup. We should just test that the image meets the spec (not that it works with Istio).

[jcchavezs]

Related corazawaf/coraza#594