fix: variable parsing error #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @geekeryy do you mind adding a failing test case for this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
==========================================
+ Coverage 82.72% 83.10% +0.38%
==========================================
Files 162 164 +2
Lines 9080 7673 -1407
==========================================
- Hits 7511 6377 -1134
+ Misses 1319 1041 -278
- Partials 250 255 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
geekeryy
changed the title
geekeryy
changed the title
|
It's impressive that it took almost three years to find this bug 🤣 Please fix the linter issue by adding a space after |
|
Thanks for this. I wonder if we truly need the commented lines. Shall we
remove them?
…On Tue, Jun 25, 2024 at 1:48 PM Juan Pablo Tosso ***@***.***> wrote:
It's impressive that it took almost three years to find this bug 🤣
Thank you for your contribution
—
Reply to this email directly, view it on GitHub
<#1087 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAXCZCVGIDW7ZAPW2WTZJFKJJAVCNFSM6AAAAABJ3IG2OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYG4ZDSMZSGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
fzipi
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue that the ParseVariables function would parse the regular expression with escape characters incorrectly
fix #1088