Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable parsing error #1087

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: variable parsing error #1087

merged 2 commits into from
Jun 26, 2024

Conversation

geekeryy
Copy link
Contributor

@geekeryy geekeryy commented Jun 25, 2024

Fixed the issue that the ParseVariables function would parse the regular expression with escape characters incorrectly

fix #1088

@geekeryy geekeryy requested a review from a team as a code owner June 25, 2024 07:44
@jcchavezs
Copy link
Member

Hi @geekeryy do you mind adding a failing test case for this?

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (4ff1f76) to head (350e2c8).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   82.72%   83.10%   +0.38%     
==========================================
  Files         162      164       +2     
  Lines        9080     7673    -1407     
==========================================
- Hits         7511     6377    -1134     
+ Misses       1319     1041     -278     
- Partials      250      255       +5     
Flag Coverage Δ
default 83.10% <100.00%> (+5.27%) ⬆️
examples 83.10% <100.00%> (+56.67%) ⬆️
ftw 83.10% <100.00%> (+35.74%) ⬆️
ftw-multiphase 83.10% <100.00%> (+33.56%) ⬆️
tinygo 83.10% <100.00%> (+7.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzipi

This comment was marked as resolved.

@fzipi fzipi changed the title fix: Variable parsing error fix: variable parsing error Jun 25, 2024
@geekeryy geekeryy changed the title fix: variable parsing error fix: variable parsing error (#1088) Jun 25, 2024
@geekeryy geekeryy changed the title fix: variable parsing error (#1088) fix: variable parsing error Jun 25, 2024
@jptosso
Copy link
Member

jptosso commented Jun 25, 2024

It's impressive that it took almost three years to find this bug 🤣
Thank you for your contribution

Please fix the linter issue by adding a space after //

@jcchavezs
Copy link
Member

jcchavezs commented Jun 25, 2024 via email

Copy link
Member

@jcchavezs jcchavezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome finding!

@jcchavezs jcchavezs requested a review from M4tteoP June 26, 2024 08:24
@fzipi fzipi merged commit 3b6497d into corazawaf:main Jun 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseVariables function parses regular expressions with escape characters incorrectly
4 participants