Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: finalizes go 1.21 bump, point to local version for crs tests, minor docs #1102

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Jul 18, 2024

@M4tteoP M4tteoP marked this pull request as ready for review July 18, 2024 22:26
@M4tteoP M4tteoP requested a review from a team as a code owner July 18, 2024 22:26
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (4ff1f76) to head (0972a37).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   82.72%   83.14%   +0.42%     
==========================================
  Files         162      164       +2     
  Lines        9080     7687    -1393     
==========================================
- Hits         7511     6391    -1120     
+ Misses       1319     1042     -277     
- Partials      250      254       +4     
Flag Coverage Δ
default 83.14% <100.00%> (+5.30%) ⬆️
examples 83.14% <100.00%> (+56.71%) ⬆️
ftw 83.14% <100.00%> (+35.77%) ⬆️
ftw-multiphase 83.14% <100.00%> (+33.59%) ⬆️
tinygo 83.14% <100.00%> (+7.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -37,8 +40,7 @@ func (a *denyFn) Evaluate(r plugintypes.RuleMetadata, tx plugintypes.Transaction
status := r.Status()
// deny action defaults to status 403
if status == noStatus {
// TODO(M4tteop): use http.StatusForbidden once we drop Go 1.20 support. http pkg unsupported with TinyGo and Go <1.20
status = 403
status = http.StatusForbidden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ on using constants instead of numbers

@M4tteoP M4tteoP merged commit 18c120b into corazawaf:main Jul 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants