fix: broken TestInspectFile on windows #1133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small for TestInspectFile on windows. As windows is not able to run /bin/echo I choose an alternative for this platform.
Why tasklist.exe?
I also changed the argument from "" to "/?" to ensure that tasklist.exe does not do anything. On *nix this does not have any impact.
Why not XYZ?
I was unable to find a suitable platform independent alternative, as "finding" an available binary (e.g. go) at runtime would make the test more complex than the actual code.