Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MULTIPART_STRICT_ERROR, updates CRS tests to v4.6.0 #1166

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Oct 5, 2024

  • Fixes propagation of MultipartStrictError. MultipartStrictError was internally set thanks to feat: set MULTIPART_STRICT_ERROR value when mutipart fails to parse #1098, but it was not returned when a rule was asking for MULTIPART_STRICT_ERROR value. Engine tests have been added to close the circle.
  • CRS has been updated to v4.6.0 bringing some more Multipart tests. All of them required overrides for Coraza, being tailored to match ModSec-specific log strings. Besides the overrides, all of them are now passing as expected.

Supersedes #1163

@M4tteoP M4tteoP changed the title Multipart Fixes MULTIPART_STRICT_ERROR, updates CRS tests to v4.6.0 Oct 5, 2024
@M4tteoP M4tteoP changed the title Fixes MULTIPART_STRICT_ERROR, updates CRS tests to v4.6.0 fix: MULTIPART_STRICT_ERROR, updates CRS tests to v4.6.0 Oct 5, 2024
@fzipi
Copy link
Member

fzipi commented Oct 5, 2024

Nice find!

@M4tteoP M4tteoP marked this pull request as ready for review October 5, 2024 14:12
@M4tteoP M4tteoP requested a review from a team as a code owner October 5, 2024 14:12
@M4tteoP M4tteoP merged commit e1c5b1b into main Oct 5, 2024
6 checks passed
@M4tteoP M4tteoP deleted the multipart branch October 5, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants