-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle additional broken macro definitions #1180
Conversation
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
thanks for this @fzipi would you mind isolating the fix in this PR and move the other enhancements into another PR? |
@jcchavezs moved additional fixes to #1181 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
m.tokens = append(m.tokens, macroToken{ | ||
text: currentToken.String(), | ||
variable: variables.Unknown, | ||
key: "", | ||
}) | ||
currentToken.Reset() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder about this change although I know tests passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revert it if too much uncertainty.
what
why
%
#1178.