Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Use mage commands in CI instead of pre-commit #356

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

anuraaga
Copy link
Contributor

Same as #355

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.

Make sure that you've checked the boxes below before you submit PR:

Thanks for your PR ❤️

@jcchavezs jcchavezs merged commit 4d6009f into corazawaf:v3/dev Aug 25, 2022
@jptosso
Copy link
Member

jptosso commented Aug 25, 2022

I didn't want to merge this yet as there is an issue with the github action, it's not validating the controls from the config file. That's why v2 is still using the pre-commit

@jcchavezs
Copy link
Member

jcchavezs commented Aug 25, 2022

I did not know that @jptosso. This PR looked good to me and I did not see any concern about it in the last days so I felt like merging. Let's use request changes or comment next time :).

Shall I revert it?

@anuraaga
Copy link
Contributor Author

@jptosso I'm also happy to fix forward, could you point out what "validating the controls from the config file" is? I'm not too sure where that check is

@anuraaga anuraaga mentioned this pull request Aug 29, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants