chore: remove all panics #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
jcchavezs
reviewed
Oct 31, 2023
| @@ -95,11 +95,13 @@ type NamedCollectionNames struct { | |||
| } | |||
|
|
|||
| func (c *NamedCollectionNames) FindRegex(key *regexp.Regexp) []types.MatchData { | |||
| panic("selection operator not supported") | |||
| // not supported | |||
| return []types.MatchData{} | |||
There was a problem hiding this comment.
Not sure about this one. The panic feels like a programming error cc @anuraaga
There was a problem hiding this comment.
@anuraaga Can you comment on this one? 🙏
There was a problem hiding this comment.
Yeah generally we would use panics for programming errors, unimplemented methods of an interface should never be called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for precaution