Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe only failed matchers in AllOf #3

Closed
corbym opened this issue Dec 15, 2020 · 2 comments
Closed

Describe only failed matchers in AllOf #3

corbym opened this issue Dec 15, 2020 · 2 comments
Milestone

Comments

@corbym
Copy link
Owner

corbym commented Dec 15, 2020

AllOf reports all matcher's descriptions when it fails.

Given a number of matchers, when less than all of them fail, we should only report the description of the failing matchers.

@jpolack
Copy link
Contributor

jpolack commented Dec 17, 2020

Would be a nice feature, because if I understand right the description has to be changed based on the childMatchers' .Matches result.

Enabling this would make possible to write better descriptions/actuals in general

@corbym corbym added this to the 1.0.5 milestone Dec 18, 2020
@corbym corbym modified the milestones: 1.0.5, 1.0.7 Dec 26, 2020
@corbym corbym changed the title Describe only failed matchers in AnyOf Describe only failed matchers in AllOf Mar 15, 2023
@corbym
Copy link
Owner Author

corbym commented Mar 15, 2023

not sure what I was thinking here, cause it makes no sense for anyOf to fail matching less than all - its criteria is to match ANY of the matchers and pass.
I must have meant AllOf..

@corbym corbym closed this as completed in daa3042 Mar 15, 2023
corbym pushed a commit that referenced this issue Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants