Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Corcel 1.x model with the 2.* notation #63

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

marcoboom
Copy link
Contributor

Fix an issue for the repeater component for getting the meta data of the base object when that base object is a taxonomy.

The instanceof check was performing on a Corcel model in the 1.x style. I replaced that with the namespace of the 2.x version.

@jgrossi
Copy link
Member

jgrossi commented Feb 9, 2018

Thanks for that 🍻

@jgrossi jgrossi merged commit 32ecfc9 into corcel:develop Feb 9, 2018
@marcoboom
Copy link
Contributor Author

@jgrossi Thanks, when are you planning a new release?

@fidovandenbos
Copy link

@jgrossi Do you have any estimation for the new release ?

@jgrossi
Copy link
Member

jgrossi commented Mar 9, 2018

Hey @marcoboom @fidovandenbos sorry about being MIA. Released at 1.1.0. Thanks! 🎉👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants