Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minato): impl $.get #109

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat(minato): impl $.get #109

merged 4 commits into from
Sep 16, 2024

Conversation

Hieuzest
Copy link
Contributor

@Hieuzest Hieuzest commented Sep 1, 2024

Motivation

object[key] / array[index]

Eval

// Field of object only support string constant
get<T extends object, K extends keyof T, A extends boolean>(x: Term<T, A>, key: K): Expr<T[K], A>
// Index of array can be of any Expr<number>
get<T extends any, A extends boolean>(x: Array<T, A>, index: Term<number, A>): Expr<T, A>

Query

Reverted*

Modifier

Not yet supported

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (c71ad3e) to head (c98f766).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   98.99%   99.01%   +0.02%     
==========================================
  Files          39       39              
  Lines       13488    13577      +89     
  Branches     3322     3338      +16     
==========================================
+ Hits        13352    13443      +91     
+ Misses        136      134       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hieuzest Hieuzest marked this pull request as ready for review September 2, 2024 07:24
@shigma shigma merged commit 2e0327a into cordiverse:master Sep 16, 2024
26 checks passed
@shigma shigma changed the title feat(minato): impl $.get feat(minato): impl $.get Sep 16, 2024
@Hieuzest Hieuzest deleted the feat-get branch November 8, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants