fix(minato): join selections, join multiple tables #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 93.25% 93.34% +0.09%
==========================================
Files 28 28
Lines 8004 8058 +54
Branches 1947 1995 +48
==========================================
+ Hits 7464 7522 +58
+ Misses 540 536 -4 ☔ View full report in Codecov by Sentry. |
shigma
reviewed
Dec 23, 2023
packages/sql-utils/src/index.ts
Outdated
Comment on lines
9
to
11
| return value.startsWith('(') && value.endsWith(')') && Array.from(value).slice(1).reduce((count, char) => | ||
| char === '(' ? count + 1 : char === ')' ? count - 1 : count === 0 ? -Infinity : count | ||
| , 1) === 0 |
There was a problem hiding this comment.
I'm confused. Why do we need the reduce() === 0 here?
Co-authored-by: Shigma <shigma10826@gmail.com>
shigma
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.