Merge pull request #511 from cordova-rtc/bugs/getStats

fix RTCPeerConnection.prototype.getStats.length to match features detection
cordova-rtc · May 24, 2020 · d4eeea4 · d4eeea4
2 parents ac93724 + df3105c
commit d4eeea4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/dist/cordova-plugin-iosrtc.js b/dist/cordova-plugin-iosrtc.js
@@ -2495,6 +2495,10 @@ function RTCStatsResponse(data) {
  return data;
  };
 
+ this.forEach = function (callback, thisArg) {
+ return data.forEach(callback, thisArg);
+ };
+
  this.namedItem = function () {
  return null;
  };
@@ -3133,7 +3137,7 @@ function requestPermission(needMic, needCamera, callback) {
 }
 
 function callbackifyMethod(originalMethod) {
- return function () {
+ return function (arg) { // jshint ignore:line
  var success, failure,
  originalArgs = Array.prototype.slice.call(arguments);
 
@@ -3180,6 +3184,7 @@ function restoreCallbacksSupport() {
  callbackifyPrototype(RTCPeerConnection.prototype, 'setRemoteDescription');
  callbackifyPrototype(RTCPeerConnection.prototype, 'setLocalDescription');
  callbackifyPrototype(RTCPeerConnection.prototype, 'addIceCandidate');
+ callbackifyPrototype(RTCPeerConnection.prototype, 'getStats');
 }
 
 function registerGlobals(doNotRestoreCallbacksSupport) {

diff --git a/js/RTCStatsResponse.js b/js/RTCStatsResponse.js
@@ -10,6 +10,10 @@ function RTCStatsResponse(data) {
  return data;
  };
 
+ this.forEach = function (callback, thisArg) {
+ return data.forEach(callback, thisArg);
+ };
+
  this.namedItem = function () {
  return null;
  };

diff --git a/js/iosrtc.js b/js/iosrtc.js
@@ -122,7 +122,7 @@ function requestPermission(needMic, needCamera, callback) {
 }
 
 function callbackifyMethod(originalMethod) {
- return function () {
+ return function (arg) { // jshint ignore:line
  var success, failure,
  originalArgs = Array.prototype.slice.call(arguments);
 
@@ -169,6 +169,7 @@ function restoreCallbacksSupport() {
  callbackifyPrototype(RTCPeerConnection.prototype, 'setRemoteDescription');
  callbackifyPrototype(RTCPeerConnection.prototype, 'setLocalDescription');
  callbackifyPrototype(RTCPeerConnection.prototype, 'addIceCandidate');
+ callbackifyPrototype(RTCPeerConnection.prototype, 'getStats');
 }
 
 function registerGlobals(doNotRestoreCallbacksSupport) {