Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New libWebRTC build please #169

Closed
saghul opened this issue Apr 25, 2016 · 9 comments
Closed

New libWebRTC build please #169

saghul opened this issue Apr 25, 2016 · 9 comments

Comments

@saghul
Copy link
Collaborator

saghul commented Apr 25, 2016

While testing the H264 support I ran into some shortcoming in the current libWebRTC build bundled with the plugin. Basically it doesn't specify the profile-level-id attribute, but doesn't really use the default (LoL). It also doesn't specify the packetization-mode.

This has since been fixed without the need for ugly workarounds on Chrome > 51, so I guess building the latest libWebRTC should do.

Reference: https://bugs.chromium.org/p/chromium/issues/detail?id=591971

PS: This would also be a good opportunity to tag the 3.0.0 release 😉

@saghul
Copy link
Collaborator Author

saghul commented Apr 25, 2016

/cc @ibc

@ibc
Copy link
Collaborator

ibc commented Apr 25, 2016

Let me do it during this week (ping me if necessary)

@saghul
Copy link
Collaborator Author

saghul commented Apr 25, 2016

Thanks! (you'll get the cake once it lands 😉 )

@saghul
Copy link
Collaborator Author

saghul commented Apr 28, 2016

So, howis my build progressing? I have a nice and sweet cake here...

@ibc
Copy link
Collaborator

ibc commented Apr 28, 2016

Ping me tomorrow morning please.

@saghul
Copy link
Collaborator Author

saghul commented Apr 29, 2016

Good morning!

@ibc
Copy link
Collaborator

ibc commented Apr 29, 2016

libwebrtc updated (being pushed right now) but there are some ObjC changes I must handed in Swift land.

@ibc
Copy link
Collaborator

ibc commented Apr 29, 2016

I see this:

a=rtpmap:107 H264/90000
a=rtcp-fb:107 ccm fir
a=rtcp-fb:107 nack
a=rtcp-fb:107 nack pli
a=rtcp-fb:107 goog-remb
a=rtcp-fb:107 transport-cc
a=fmtp:107 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f

good?

@saghul
Copy link
Collaborator Author

saghul commented Apr 29, 2016

YES, that's the Kosher SDP we are after!

🍰 🍰 🍰 🍰

@ibc ibc closed this as completed Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants