Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.2 possible issues #386

Closed
hthetiot opened this issue Sep 16, 2019 · 4 comments
Closed

5.0.2 possible issues #386

hthetiot opened this issue Sep 16, 2019 · 4 comments
Assignees
@hthetiot
Labels
bug
Milestone
5.0.2

Comments

@hthetiot
Copy link
Contributor

hthetiot commented Sep 16, 2019 •
edited
Loading

It look like there is some issue with 5.0.2 changes, I'm investigating.
Currently local stream works and render but not remote streams.

I recommend to keep using 5.0.1 for now.
@hthetiot hthetiot added the bug label Sep 16, 2019
@hthetiot hthetiot self-assigned this Sep 16, 2019
@hthetiot hthetiot added this to the 5.0.3 milestone Sep 16, 2019
@hthetiot
Copy link
Contributor Author

A fix is on his way, look like the issue is related to RTCPeerConnection and MediaStream changes.

@hthetiot hthetiot changed the title 5.0.2 issues 5.0.2 possible issues Sep 17, 2019
@hthetiot
Copy link
Contributor Author

Good news, after debugging I found that the issue was related to RTCPeerConnection.setRemoteDescription|setLocalDescription callback usage instead of promise, fixing the third party library to use Promise for this APIs calls.

@hthetiot hthetiot modified the milestones: 5.0.3, 5.0.2 Sep 17, 2019
@hthetiot
Copy link
Contributor Author

Closing for false positive.
See CHANGELOG.md "Remove callback based API"

@hthetiot
Copy link
Contributor Author

Going back to #385 :)

@hthetiot hthetiot mentioned this issue Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hthetiot hthetiot

Labels
bug
Projects
None yet
Milestone
5.0.2
Development

No branches or pull requests
1 participant
@hthetiot