Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] update libwebrtc without iosrtc custom patch to ~M54 #385

Closed
wants to merge 55 commits into from

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Sep 16, 2019

  1. This PR is a work in progress.
  2. Test it at your own risk.
  3. It as been confirmed to fix iOS 13 support.

Testing

To test task/libwebrtc-update branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/libwebrtc-update --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

TODO

  • Update webrtclib

  • Restore rtcDTMFSender

  • add turnOnSpeaker

  • add requestPermission

  • add MediaStreamRenderer.prototype.save to take MediaStream capture

  • Fix MediaStreamRenderer visible

Notes:

I will released M54 on 5.1.0 once rtcDTMFSender is completed and migrate on M69 as part of 6.0.x. See milestones Roadmap for details:

@hthetiot hthetiot added this to the 6.0.x milestone Sep 16, 2019
@hthetiot hthetiot self-assigned this Sep 16, 2019
@hthetiot
Copy link
Contributor Author

Work in progress status on real device
Image from iOS (1)

@hthetiot hthetiot mentioned this pull request Sep 16, 2019
Fix sdp in callback for addIceCandidate, and on icecandidate events
@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 1, 2019

Thank you @SejH

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 3, 2019

Note: Until rtcDTMFSender is ready JsSip may be not fully supported by this branch.

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 4, 2019

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 4, 2019

I will released M54 on 5.1.0 once rtcDTMFSender completed and migrate on M69 as part of 6.0.x.
See milestones Roadmap for details:

@hthetiot hthetiot changed the title update libwebrtc [Beta] update libwebrtc Oct 5, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 5, 2019

rtcDTMFSender need iosrtc patch workarround, cause i dont want to patch cause i dont want to rebuild M54 since I'm on M69 PR see #399

If someone is willing to provide a patched build i will merge in that PR but i doubt anyone will help.

…DTMFSender

[WIP] attempt to implement RTCPeerConnection_RTCDTMFSender_insertDTMF without  cordova-iosrtc patch for M54
@hthetiot hthetiot changed the title [Beta] update libwebrtc [Beta] update libwebrtc without iosrtc custom patch to ~M54 Oct 5, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 5, 2019

Note: This PR will not going to be released. Everything works like 5.0.4 except rtcDTMFSender (see 23789a3)

Instead this one will be released instead #399 using M69 on version 6.0.0 instead ~M54

This PR was mainly used to understand the scope of the migration from previous webrtclib versions see comment #385 (comment).

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 6, 2019

Closed in favor of #399 that will be released for version 6.0.0

@hthetiot hthetiot closed this Oct 6, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 8, 2019

For some unknown reason DTLS was not initialized in that branch making it possiblity insecure I think.
https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/libwebrtc-update/src/iosrtcPlugin.swift#L40

I confirmed master is initializing DTLS and that #399 also does.

@hthetiot hthetiot deleted the task/libwebrtc-update branch October 22, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants