-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beta] update libwebrtc without iosrtc custom patch to ~M54 #385
Conversation
…urnOnSpeaker, selectAudioOutput
… to jpegData in PluginMediaStreamRenderer.swift
Fix sdp in callback for addIceCandidate, and on icecandidate events
Thank you @SejH |
Note: Until rtcDTMFSender is ready JsSip may be not fully supported by this branch. |
I will released M54 on 5.1.0 once rtcDTMFSender completed and migrate on M69 as part of 6.0.x. |
rtcDTMFSender need iosrtc patch workarround, cause i dont want to patch cause i dont want to rebuild M54 since I'm on M69 PR see #399 If someone is willing to provide a patched build i will merge in that PR but i doubt anyone will help. |
…DTMFSender [WIP] attempt to implement RTCPeerConnection_RTCDTMFSender_insertDTMF without cordova-iosrtc patch for M54
Note: This PR will not going to be released. Everything works like 5.0.4 except rtcDTMFSender (see 23789a3) Instead this one will be released instead #399 using M69 on version 6.0.0 instead ~M54 This PR was mainly used to understand the scope of the migration from previous webrtclib versions see comment #385 (comment). |
Closed in favor of #399 that will be released for version 6.0.0 |
For some unknown reason DTLS was not initialized in that branch making it possiblity insecure I think. I confirmed master is initializing DTLS and that #399 also does. |
Testing
To test
task/libwebrtc-update
branchTODO
Update webrtclib
Restore rtcDTMFSender
add turnOnSpeaker
add requestPermission
add MediaStreamRenderer.prototype.save to take MediaStream capture
Fix MediaStreamRenderer visible
Notes:
I will released M54 on 5.1.0 once rtcDTMFSender is completed and migrate on M69 as part of 6.0.x. See milestones Roadmap for details: