libwebrtc build issues

[limch237]

I need to build my own webrtc lib due to some duplicate symbols.

I followed the steps to download code. However, there is no response when I applied the patch. I also can't find the "talk" folder.

[saghul]

The directory structure has changed and we haven't adapted the patches yet. It may take a while, sorry.

[limch237]

Thanks for your prompt reply.

I followed the steps provided by https://webrtc.org/native-code/ and managed to build the WebRTC iOS lib. However, I encountered the link errors (RTCICEServer, RTCICECandidate, RTCDTMFSender, RTCDataChannelInit, RTCVideoCapturer & RTCPair ) when I use it with iOSRTC plugin. I guessed these are the changes patched by iOSRTC plugin.

What is workaround I can try while waiting you guys to work on the issue?

[saghul]

You can look at the patches and try to adapt them yourself, I'm afraid.

[logidelic]

Also, what is the most recent libwebrtc revision that works with the current patches?

[saghul]

I don't know. We used to use svn and now they switched to git, plus the build system is now GN instead of GYP (though they are similar).

[limch237]

Google has simplified the build process and I could download the code in 1 hour.

Fetch depot tools
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git

Add depot_tools to your PATH:
export PATH=’pwd’/depot_tools:"$PATH"

Fetch webrtc
fetch --nohooks webrtc_ios
gclient sync

Build iOS Lib
cd src/webrtc/build/ios
./build_ios_libs.sh

I think you just need to apply patch directly to src/webrtc/src/objc/Framework instead of talk folder.

I am not familiar with the code. But I think you guys should be able to fix the build issue easily. Please let me know your patch and I could also test the build.

[cozzbie]

Hi @saghul any timeframe on when this will be updated?

[mruffa]

Hi Anyone interesting in splitting work on fixing patches?

[ptixed]

Do I understand correctly that even the original version of libwebrtc (13311) won't compile as supposed now? I'm facing similar problems and I don't know if this is related.

[limch237]

I have some questions

1. What are differences between the code in talk folder & sdk folder? I see there are many common files.
2. Is the webrtc lib used by iOSRTC plugin only link the talk lib instead of sdk lib?
3. What is better workaround approach? To link the code in talk lib or try to make it work with sdk lib?

[BellesoftConsulting]

Anybody got this to work? I think if we fix this bug, it will take care of a few others, especially the h264 bug #170 . I want to offer a USD $500 bounty to get both bug #249 and #170 resolved and pushed to the repo as a new installable npm build. Bounty expires in 7 days... Please post below if you are working on it...

[fbernhard]

I am adding an additional USD 500 bounty on top of @BellesoftConsulting offer to get both #249 and #170 resolved and pushed to the repo as a new installable npm build. My bounty expires in 14 days.

[BellesoftConsulting]

anyone? anyone? bueller?

It must be possible... @fbernhard Should we double our bounties to get @saghul 's attention??

[fbernhard]

@BellesoftConsulting, @saghul

Yes, I am willing to double my bounty to a total of USD 1'000 to get both #249 and #170 resolved and pushed to the repo as a new installable npm build. My bounty expires in 14 days from now.

[hthetiot]

@fbernhard still on for this offer ?
I would make invoice and make result open source.
I'm the current maintainer now.

[fbernhard]

Hi Harold, Congrats to becoming the maintainer of this project! Unfortunately, my offer is not valid anymore. We are moving away from Ionic apps to a pure browser web app. Best regards, Fabian

…

On Fri, Sep 13, 2019, 18:25 Harold Thétiot ***@***.***> wrote: @fbernhard <https://github.com/fbernhard> still on for this offer ? I would make invoice and make result open source. I'm the current maintainer now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#249?email_source=notifications&email_token=AAQNVNECQSRQR5XXI2T5Q33QJO5JJA5CNFSM4C4VAODKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6VQ2WY#issuecomment-531303771>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQNVNGBTQEMSYFQBYCFMJ3QJO5JJANCNFSM4C4VAODA> .

[hthetiot]

@fbernhard Thank you for reply.
I do understand.

I'm will work on libwebrtc upgrade when i have time and I already started exposing RTCPeerConnection.addTrack|remoteTrack for version 6.0.0 inside release 5.0.2

[hthetiot]

Done #385

[hthetiot]

Fixed by #399