Implement RTCPeerConnection.createDTMFSender #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the DTMF patch.
|
I trust you (or die). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Before you jump to replying "DTMF?! heresy!" please note I have not enjoyed implementing this pull request)
So, DTMF o'clock. This PR implements the RTCDMFSender functionality through RTCPeerConnection.createDTMFSender. Yes, it's supposed to be deprecated, but Chrome is one year in and they haven't moved away from it, so here we are.
In order to get this working 4 parts were needed:
I've come to call this The Onion model: layers atop layers of abstraction, and the deeper you dig, the more you cry. But it works!
I digress... @ibc please take a look. I tried to break it down into small commits for easier review.
Standard warranty applies: works on my devices.