Allow setting video.srcObject (should fix issues such as #262)

[ibc]

It may work (or not, since I don't have an iOS device to check it).

[saghul]

Code LGTM, but I need to test it before merging.

[ggozad]

I am also hit by #262 . iOS client streams fine and the video is seen on the other side, but not displayed on the iOS client. Instead I see a native play video button.
Applying this did not resolve #262, I did see though the play button using .srcObject which I would not before.

[saghul]

@ggozad That has nothing to do with this AFAICT. See the FAQ https://github.com/BasqueVoIPMafia/cordova-plugin-iosrtc/blob/master/FAQ.md for how to remove the play button.

[ggozad]

@saghul You misunderstand. The issue is not the play button, the issue is the video does not render.

[ggozad]

@saghul perhaps you can reopen #262 as a few people have this problem. I am posting here since @ibc thought that this would actually fix #262

[saghul]

@ggozad I cannot reproduce the problem. Unless there is a way for me to reproduce it there is nothing I can do to fix it. 🤷‍♂️

[ggozad]

@saghul not being able to reproduce a bug does not mean it does not exist. You are far more familiar with the codebase than I am, could you suggest what kind of test you would like to see? Would it be helpful to make an example app with the bug?

[saghul]

not being able to reproduce a bug does not mean it does not exist.

I don't mean to sound smug, but video rendering is one of the primary goals of this plugin. It's the main thing I test before making a release, and we just made one, so I tested my existing app (since we had made significant changes to the plugin, for Swift 3 support) and it continues to work as expected.

Would it be helpful to make an example app with the bug?

Definitely.

[dunnky]

I was also seeing something like #262 - PR worked great in my tests 👍

[ibc]

@uunp do you mean that this PR works fine? To be clear: this PR enables videoElement.srcObject = mediaStream. Before this PR, the only way to make it work was by doing the legacy videoElement.src = URL.createObjectURL(mediaStream).

[dunnky]

@ibc Correct, this PR works fine in my tests when using videoElement.srcObject = mediaStream. Appreciate the work!

[ibc]

Nice to know. I will merge it so users can use the master branch (while waiting after holidays for @saghul to release a new NPM version).

[dunnky]

@ibc Sorry, forgot about this - I did have to run gulp browserify to get your changes added to dist/cordova-plugin-iosrtc.js.