Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Established audio input priority #387

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Established audio input priority #387

merged 1 commit into from
Sep 17, 2019

Conversation

CSantosM
Copy link
Contributor

Hello @hthetiot ,

This changes add the audio input priority.

Before these changes, the Built-in Microphone was set up by default. Now, the priority established is Wired microphone > Wireless microphone > built-in microphone.

Take a look.
Regards

This changes add  the audio input priority. 
The priority established is wired > wireless > built-in microphone
@hthetiot
Copy link
Contributor

hthetiot commented Sep 17, 2019

@CSantosM Cool. Thank you for this changes.
Just to be sure before merge, did you test that changes on actual device ?

Hey, just wanted to ask, I noticed a drop in video quality on 5.0.2 from the Native camera did you notice that too ?

@hthetiot hthetiot assigned hthetiot and CSantosM and unassigned hthetiot Sep 17, 2019
@hthetiot hthetiot self-requested a review September 17, 2019 18:03
@hthetiot hthetiot added this to the 5.0.3 milestone Sep 17, 2019
@hthetiot hthetiot merged commit 32f00c3 into cordova-rtc:master Sep 17, 2019
@hthetiot
Copy link
Contributor

hthetiot commented Sep 17, 2019

@CSantosM Merged if you could test 5.0.3 master for me would help me to confirm your changes and my changes are ok.

To test master branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#master --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

@CSantosM CSantosM changed the title Estabished audio input priority Established audio input priority Sep 18, 2019
@CSantosM
Copy link
Contributor Author

CSantosM commented Sep 18, 2019

Hello @hthetiot ,

Merged if you could test 5.0.3 master for me would help me to confirm your changes and my changes are ok.

I have could test the changes in master and they are working fine.

I have done the following tests:

  1. Join with wired mic connected --> Wired mic is selected
  2. Join with bluetooth and wired mic connected --> Wired mic is selected
  3. Join with bluetooth mic connected --> Bluetooth mic is selected
  4. Join with no devices connected --> Built-In mic selected

Hey, just wanted to ask, I noticed a drop in video quality on 5.0.2 from the Native camera did you notice that too ?

I have test with iPhone 7 Plus on v 4.0.2 and with iPhone 7 on master (v 5.0.2) and I didn't appreciate a loss of video quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants