Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/improve hook cycle #402

Merged
merged 13 commits into from
Oct 9, 2019
Merged

Task/improve hook cycle #402

merged 13 commits into from
Oct 9, 2019

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Oct 5, 2019

No description provided.

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 5, 2019

@abardik This PR will do the same as cordova-plugin-add-swift-support and allow you to run on phone gap build. The reason the hook do not works for you it's because you are adding the plugin after the platform. https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/docs/Building.md#building-steps

This PR should fix that and execute the hook after prepare phase, however you still need Xcode 10.3 minimum

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 6, 2019

Will add Xcode version detection on the hook for having people stop report false positive because they dont match the requirements aka Xcode 10.3

@hthetiot hthetiot requested a review from saghul October 6, 2019 14:01
@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 6, 2019

May be before_build is better not sure but works properly now when you add plugin after the platform.

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 6, 2019

Actually, replying to myself, after_prepare make sense if you want to build with Xcode instead of Cordova cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant