Restore Callbacks Support on registerGlobals getUserMedia|enumerateDevices RTCPeerConnection.prototype.createAnswer|createOffer|setRemoteDescription|setLocalDescription|addIceCandidate support for JsSIP, SIP.js and sipML5 #404

hthetiot · 2019-10-07T21:02:11Z

Tested on JsSIP and SIP.js with FreeSWITCH (Sorry sipML5 is too much for me)

Testing

To test task/restore-callbacks-support branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/restore-callbacks-support --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

onerinas · 2019-11-02T23:42:33Z

dist/cordova-plugin-iosrtc.js

@@ -2529,6 +2578,12 @@ function registerGlobals() {
 navigator.webkitGetUserMedia = getUserMedia;
 navigator.mediaDevices.getUserMedia = getUserMedia;
 navigator.mediaDevices.enumerateDevices = enumerateDevices;
+
+ // Restore Callback support
+ if (!doNotRestoreCallbacksSupport) {


@hthetiot should this be above navigator.webkitGetUserMedia = getUserMedia;?
I'm facing an issue where it still throws an error while using getUserMedia

hthetiot added 2 commits October 7, 2019 23:00

implement restoreCallbacksSupport into iosrtc.js called on registerGl…

1a395c5

…obals method to restore getUserMedia|enumerateDevices RTCPeerConnection.prototype.createAnswer|createOffer|setRemoteDescription|setLocalDescription|addIceCandidate support for JsSIP, SIP.js and sipML5

update dist/cordova-plugin-iosrtc.js build with restoreCallbacksSupport

815bc38

hthetiot added enhancement getUserMedia boulet labels Oct 7, 2019

hthetiot added this to the 5.0.5 milestone Oct 7, 2019

hthetiot self-assigned this Oct 7, 2019

hthetiot mentioned this pull request Oct 7, 2019

TypeError: originalMediaStreamTrack is not a function #403

Closed

hthetiot added third party library support and removed boulet labels Oct 7, 2019

hthetiot mentioned this pull request Oct 7, 2019

[master] Outgoing video stream is no longer working on iOS 13 and Xcode 11 beta #375

Closed

hthetiot merged commit b3d8d0b into master Oct 9, 2019

hthetiot deleted the task/restore-callbacks-support branch October 22, 2019 13:30

onerinas reviewed Nov 2, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore Callbacks Support on registerGlobals getUserMedia|enumerateDevices RTCPeerConnection.prototype.createAnswer|createOffer|setRemoteDescription|setLocalDescription|addIceCandidate support for JsSIP, SIP.js and sipML5 #404

Restore Callbacks Support on registerGlobals getUserMedia|enumerateDevices RTCPeerConnection.prototype.createAnswer|createOffer|setRemoteDescription|setLocalDescription|addIceCandidate support for JsSIP, SIP.js and sipML5 #404

hthetiot commented Oct 7, 2019 •

edited

Loading

onerinas Nov 2, 2019

Restore Callbacks Support on registerGlobals getUserMedia|enumerateDevices RTCPeerConnection.prototype.createAnswer|createOffer|setRemoteDescription|setLocalDescription|addIceCandidate support for JsSIP, SIP.js and sipML5 #404

Restore Callbacks Support on registerGlobals getUserMedia|enumerateDevices RTCPeerConnection.prototype.createAnswer|createOffer|setRemoteDescription|setLocalDescription|addIceCandidate support for JsSIP, SIP.js and sipML5 #404

Conversation

hthetiot commented Oct 7, 2019 • edited Loading

Testing

onerinas Nov 2, 2019

Choose a reason for hiding this comment

hthetiot commented Oct 7, 2019 •

edited

Loading