Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clean WebRTC.framework build with x86 and arm support #412

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Oct 21, 2019

Use clean WebRTC.framework build with x86 and arm support, remove debug patches.

Remove custom patches (RTCVideoFrame.h, RTCEAGLVideoView.h)

Import RTCMTLVideoView.h to fix Metal related crashes later.

Same M69 tree, with the following backports:

https://webrtc.googlesource.com/src/+/48fcf943fd2a4d52f6e77d7f99eccd1aac577c43
https://webrtc.googlesource.com/src/+/29f9cd9358ee470ced793627139de86f799a8981%5E%21/
https://webrtc.googlesource.com/src/+/3955a5022cb5457f87bc8caa4dbd3c8f4f26f506

Testing

To test task/m69-x86-arm branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/m69-x86-arm --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

@oscarvadillog
Copy link

@hthetiot merge into 6.x?

@hthetiot
Copy link
Contributor Author

Yeah let do that @oscarvadillog Let be crazy :)

@hthetiot hthetiot merged commit 5a047f0 into master Oct 24, 2019
@hthetiot hthetiot added this to the 6.0.0 milestone Oct 25, 2019
@hthetiot hthetiot self-assigned this Oct 25, 2019
@hthetiot hthetiot deleted the task/m69-x86-arm branch October 28, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants