Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
aspectRatio
(height is not set based on width and aspect ratio where 4/3 is the default aspect ratio)Todo
getConstrainRangeValues
needs to work well with bothInt64
andFloat32
(since aspectRatio is passed asNSNumber
=>Float32
)This has been tested in conjunction with #416 and #407 with
janus-gateway
as the backend, an iPhone XR with iOS 13.1.2 and ios-cordova 4.5.5 (downgraded manually) and H264 🚀