Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add English facingLabel suffix if localizedName does not match for facing detection using label, fix PluginEnumerateDevices ordered array #446

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Add English facingLabel suffix if localizedName does not match for facing detection using label, fix PluginEnumerateDevices ordered array #446

merged 1 commit into from
Nov 21, 2019

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Nov 18, 2019 •
edited
Loading

Testing

To test task/getAllVideoDevices-facing-label-and-order branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/getAllVideoDevices-facing-label-and-order --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

@hthetiot
Add English facingLabel suffix if localizedName does not match for f…
5e45970 
…acing detection using label, fix PluginEnumerateDevices ordered array
@hthetiot hthetiot self-assigned this Nov 18, 2019
@hthetiot hthetiot added this to the 6.0.4 milestone Nov 18, 2019
@hthetiot hthetiot mentioned this pull request Nov 18, 2019
Closed
@hthetiot
Copy link
Contributor Author

Related #440 #155

@hthetiot hthetiot merged commit 55cb0ad into master Nov 21, 2019
@hthetiot hthetiot mentioned this pull request Nov 21, 2019
Closed
@hthetiot hthetiot deleted the task/getAllVideoDevices-facing-label-and-order branch June 30, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hthetiot hthetiot

Labels
bug enhancement
Projects
None yet
Milestone
6.0.4
Development

Successfully merging this pull request may close these issues.
1 participant
@hthetiot