Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve video constraints (width|height|aspectRatio|frameRate).(ideal|exact) and add (aspectRatio|frameRate|facingMode).(ideal|exact) support enhancement #451

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Improve video constraints (width|height|aspectRatio|frameRate).(ideal|exact) and add (aspectRatio|frameRate|facingMode).(ideal|exact) support enhancement #451

merged 3 commits into from
Nov 21, 2019

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Nov 20, 2019 •
edited
Loading

Testing

To test task/getUserMedia-constraints branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/getUserMedia-constraints --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

This was referenced Nov 20, 2019
Closed
Closed
@hthetiot hthetiot self-assigned this Nov 20, 2019
@hthetiot hthetiot added this to the 6.0.4 milestone Nov 20, 2019
@hthetiot hthetiot changed the title mprove video constraints (width|height|aspectRatio|frameRate).(ideal|exact) and add (aspectRatio|frameRate|facingMode).(ideal|exact) support enhancement Improve video constraints (width|height|aspectRatio|frameRate).(ideal|exact) and add (aspectRatio|frameRate|facingMode).(ideal|exact) support enhancement Nov 21, 2019
@hthetiot hthetiot merged commit 5804933 into master Nov 21, 2019
@hthetiot hthetiot deleted the task/getUserMedia-constraints branch June 30, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hthetiot hthetiot

Labels
bug enhancement
Projects
None yet
Milestone
6.0.4
Development

Successfully merging this pull request may close these issues.
1 participant
@hthetiot