Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removeStream and add real Ids with UUID suffix to PluginMediaStream and PluginMediaStreamTrack #460

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Fix removeStream and add real Ids with UUID suffix to PluginMediaStream and PluginMediaStreamTrack #460

merged 3 commits into from
Jan 28, 2020

Conversation

hthetiot
Copy link
Contributor

  • fix PeerConnection removestream to use PluginMediaStream.id instead of RTCMediaStream.streamId
  • suffix PluginMediaStreamTrack.id with real PluginMediaStreamTrack.streamId
  • fix PeerConnection removestream to use PluginMediaStream.id instead of RTCMediaStream.streamId

@hthetiot hthetiot added this to the 6.0.6 milestone Jan 27, 2020
@hthetiot hthetiot self-assigned this Jan 27, 2020
@hthetiot hthetiot changed the title Bugs/remove stream Fixx removeStream and add real Ids with UUID suffix to PluginMediaStream and PluginMediaStreamTrack Jan 27, 2020
@hthetiot
Copy link
Contributor Author

This fix multi-stream support from Chrome/Firefox/Safari for Signaling that validate the StreamId that should be received on the remote for security.

@hthetiot hthetiot changed the title Fixx removeStream and add real Ids with UUID suffix to PluginMediaStream and PluginMediaStreamTrack Fix removeStream and add real Ids with UUID suffix to PluginMediaStream and PluginMediaStreamTrack Jan 27, 2020
@hthetiot
Copy link
Contributor Author

Regression was Caused by stupid Janus requirement here #447

@hthetiot hthetiot merged commit 4b9ea40 into master Jan 28, 2020
@hthetiot hthetiot added the bug label Jan 30, 2020
@hthetiot hthetiot deleted the bugs/removeStreamId branch June 30, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hthetiot hthetiot

Labels
bug
Projects
None yet
Milestone
6.0.6
Development

Successfully merging this pull request may close these issues.
1 participant
@hthetiot