pull out initAudioDevices from the constructor into its own api #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That may break the behavior of previous version. |
|
Yeah this is breaking, and people will need to use the newly added method.
…On Tue, May 19, 2020 at 2:55 AM Harold Thétiot ***@***.***> wrote:
That may break the behavior of previous version.
I need to test and we may need to make a breaking change notes.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#503 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASRS6QQM5NZRM7YI6GQI4LRSJJSRANCNFSM4MX4DPVA>
.
|
|
Actually I think maybe through settings in config.xml the behaviour can
change to the new one if people want. Let me take another look
…On Tue, May 19, 2020 at 10:34 AM Andrew Tan ***@***.***> wrote:
Yeah this is breaking, and people will need to use the newly added method.
On Tue, May 19, 2020 at 2:55 AM Harold Thétiot ***@***.***>
wrote:
> That may break the behavior of previous version.
> I need to test and we may need to make a breaking change notes.
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <#503 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASRS6QQM5NZRM7YI6GQI4LRSJJSRANCNFSM4MX4DPVA>
> .
>
|
|
Thank you @andrewvmail |
|
@hthetiot what do you think about this latest commits I did? now it shouldn't break |
|
I like it a lot @andrewvmail I will double check on my side. |
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.