Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement RTCRtpSender-replaceTrack SHAM #544

Closed
wants to merge 15 commits into from
Closed

implement RTCRtpSender-replaceTrack SHAM #544

wants to merge 15 commits into from

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Jul 17, 2020 •
edited
Loading

Fix #491

Testing

To test task/RTCRtpSender-replaceTrack branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/RTCRtpSender-replaceTrack --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

@hthetiot hthetiot mentioned this pull request Jul 17, 2020
Closed
@hthetiot hthetiot self-assigned this Jul 17, 2020
@hthetiot hthetiot added this to the 6.0.x milestone Jul 21, 2020
@hthetiot hthetiot added enhancement webrtc-api webrtc-api related labels Jul 21, 2020
@ccvlad ccvlad mentioned this pull request Jul 30, 2020
Open
@hthetiot hthetiot modified the milestones: 6.0.x, 6.0.14 Sep 1, 2020
@hthetiot hthetiot changed the title implement RTCRtpSender-replaceTrack SHIM implement RTCRtpSender-replaceTrack SHAM Sep 15, 2020
@hthetiot hthetiot mentioned this pull request Sep 16, 2020
Closed
3 tasks
@hthetiot hthetiot modified the milestones: 6.0.14, 6.0.x Sep 24, 2020
@duongduckien
Copy link

Screen Shot 2020-10-11 at 17 19 24
The plugin has errors when changes camera.

@hthetiot
Copy link
Contributor Author

thank you @duongduckien i will look into it

@hthetiot hthetiot modified the milestones: 6.0.x, 6.0.15 Oct 16, 2020
@hthetiot hthetiot removed the bug label Oct 16, 2020
@hthetiot
Copy link
Contributor Author

Please try this PR see testing instructions:
#587

Tested example:

var newTrack = localStream.getVideoTracks()[0].clone();
var sender = pc1.getSenders()[0];
sender.replaceTrack(newTrack);

@hthetiot
Copy link
Contributor Author

closed in favor of #587

@hthetiot hthetiot closed this Oct 17, 2020
@hthetiot hthetiot deleted the task/RTCRtpSender-replaceTrack branch October 17, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hthetiot hthetiot

Labels
enhancement webrtc-api webrtc-api related
Projects
None yet
Milestone
6.0.15
Development

Successfully merging this pull request may close these issues.

Problem with change camera during video call (replaceTrack is not a function)
2 participants
@hthetiot @duongduckien